About failing test in tar-ball because of missing wav files...

Moderators: khz, MattKingUSA, deva, muldjord

User avatar
deva
Established Member
Posts: 118
Joined: Sun Oct 23, 2016 10:15 am
Contact:

About failing test in tar-ball because of missing wav files...

Postby deva » Sun Oct 30, 2016 8:12 am

Currently the unit tests (make check) cannot be performed when running from the tar-ball source tree.
The reason is that the test folder in the git tree contains a lot wav files used by the tests and these files are not (yet) included in the tarball.

The question is:
Do we even want to include these files in the tar-ball? They are rather big (29MB) and has no value whatsoever to the end-user.

User avatar
Glocke
Established Member
Posts: 15
Joined: Mon Oct 24, 2016 4:54 pm

Re: About failing test in tar-ball because of missing wav files...

Postby Glocke » Sun Oct 30, 2016 9:21 am

I see unit testing as a dev-thing, not an enduser-task. So I'd not include that wav files, but refer to it through readme.
  • Bass player & vocalist of Breaper (Death Metal, Thuringia/Germany)
  • Minor dev of DrumGizmo (LGPLv3 Drumsampling Tool)
  • Dev & game artist of Racod's Lair (Pixelart Dungeoncrawler)

chaot4
Established Member
Posts: 39
Joined: Sat Apr 16, 2016 9:59 am

Re: About failing test in tar-ball because of missing wav files...

Postby chaot4 » Sun Oct 30, 2016 4:32 pm

As viccuad said in the IRC channel: Debian tries to "make check" as many packages as possible before providing them. Our "make check" runs the unit tests. I think it makes sense to provide this to package maintainers.

An idea I already had a while back would be to just algorithmically generate (e.g., random with a fixed seed) a test drumkit and then check with this one. Then we wouldn't need much memory for this and still provide the unit tests for the tarballs.

Oh, and to also answer deva's initial question: No, I don't think we want to include 28MB just for the tests. Especially when we can also just solve it using the above mentioned approach.

User avatar
deva
Established Member
Posts: 118
Joined: Sun Oct 23, 2016 10:15 am
Contact:

Re: About failing test in tar-ball because of missing wav files...

Postby deva » Sun Oct 30, 2016 4:56 pm

Algorithmically generating the test wav files is a brilliant idea. They don't have to sound anything like a drum, just be there and contain samples with varying values.
A simple white-noise generator should do the trick.

chaot4
Established Member
Posts: 39
Joined: Sat Apr 16, 2016 9:59 am

Re: About failing test in tar-ball because of missing wav files...

Postby chaot4 » Wed Nov 02, 2016 6:16 am

I added this point to the roadmap and assigned myself.

User avatar
deva
Established Member
Posts: 118
Joined: Sun Oct 23, 2016 10:15 am
Contact:

Re: About failing test in tar-ball because of missing wav files...

Postby deva » Wed Nov 02, 2016 1:38 pm

Awesome! :-D

chaot4
Established Member
Posts: 39
Joined: Sat Apr 16, 2016 9:59 am

Re: About failing test in tar-ball because of missing wav files...

Postby chaot4 » Wed Apr 12, 2017 9:28 am

Just for the record: we now generate the wav files algorithmically and this is on master since quite some time.


Return to “Development”

Who is online

Users browsing this forum: No registered users and 1 guest